From 023a149be9fb67dddd68ba2a5c013e13cec1c26e Mon Sep 17 00:00:00 2001 From: Xiaodong Date: Mon, 3 Jul 2017 18:12:54 +0800 Subject: [PATCH] Refine Variable name & Comment for better readibility (#1) * Update app.py * Update admin.html --- app.py | 4 ++-- templates/admin.html | 12 +++++++----- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/app.py b/app.py index ee1bde1..6a7478b 100644 --- a/app.py +++ b/app.py @@ -85,13 +85,13 @@ def FUN_add_user(): user_table = zip(range(1, len(user_list)+1),\ user_list,\ [x + y for x,y in zip(["/delete_user/"] * len(user_list), user_list)]) - return(render_template("admin.html", id_is_duplicated = True, users = user_table)) + return(render_template("admin.html", id_to_add_is_duplicated = True, users = user_table)) if " " in request.form.get('id') or "'" in request.form.get('id'): user_list = list_users() user_table = zip(range(1, len(user_list)+1),\ user_list,\ [x + y for x,y in zip(["/delete_user/"] * len(user_list), user_list)]) - return(render_template("admin.html", id_is_invalid = True, users = user_table)) + return(render_template("admin.html", id_to_add_is_invalid = True, users = user_table)) else: add_user(request.form.get('id'), request.form.get('pw')) return(redirect(url_for("FUN_admin"))) diff --git a/templates/admin.html b/templates/admin.html index c045e35..55ec2a1 100644 --- a/templates/admin.html +++ b/templates/admin.html @@ -2,14 +2,16 @@ {% block page_title %}Admin Dashboard{% endblock %} {% block body %} {{ super() }} - - {% if id_is_duplicated %} + + {# only invoked when failed adding new ID due to duplication #} + {% if id_to_add_is_duplicated %}
Warning! The account name already exists.
{% endif %} - - {% if id_is_invalid %} + + {# only invoked when failed adding new ID due to invalid character #} + {% if id_to_add_is_invalid %}
Warning! The account name is invalid.
@@ -67,4 +69,4 @@ -{% endblock %} \ No newline at end of file +{% endblock %}